Skip to content

[5.5][Async Refactoring] Get semantics providing expr to decide if call is to completion handler #38268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 6, 2021

Example

Orignal code

func test(_ completion: (String?, Error?) -> Void) {
  return (completion("", nil))
}

Old Refactoring Result

func test() async throws -> String {
  return (<#completion#>("", nil))
}

New Refactoring Result

func test() async throws -> String {
  return ""
}

@ahoppen ahoppen added the r5.5 label Jul 6, 2021
@ahoppen ahoppen requested a review from a team as a code owner July 6, 2021 09:00
@ahoppen ahoppen marked this pull request as draft July 6, 2021 09:02
… to completion handler

Resolves rdar://78011350
@ahoppen ahoppen force-pushed the pr-5.5/check-semantics-expr-for-completion-handler-call branch from cbdc05b to c375d14 Compare July 7, 2021 23:02
@ahoppen
Copy link
Member Author

ahoppen commented Jul 7, 2021

@swift-ci Please test

@ahoppen ahoppen marked this pull request as ready for review July 7, 2021 23:02
@ahoppen ahoppen requested a review from akyrtzi July 7, 2021 23:02
@ahoppen
Copy link
Member Author

ahoppen commented Jul 8, 2021

Windows failures is unrelated.

@ahoppen ahoppen merged commit dd43b59 into swiftlang:release/5.5 Jul 8, 2021
@ahoppen ahoppen deleted the pr-5.5/check-semantics-expr-for-completion-handler-call branch July 8, 2021 07:44
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants