Implement differently logic to strip and copy the tvos libraries #38275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic could fail silently to copy the library if the i386
slice is not present in the first place (like it is the case for
`libclang_rt.tvos.a` in Xcode 13.0 beta 1) -- this will avoid errors
like
```
Undefined symbols for architecture arm64:
"___isPlatformVersionAtLeast", referenced from:
swift::initializeProtocolLookup() in ImageInspectionMachO.cpp.o
swift::initializeProtocolConformanceLookup() in
ImageInspectionMachO.cpp.o
swift::initializeTypeMetadataRecordLookup() in
ImageInspectionMachO.cpp.o
swift::initializeDynamicReplacementLookup() in
ImageInspectionMachO.cpp.o
```
This is a backport of swiftlang#38262
Addresses rdar://80209915
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
|
@swift-ci please test |
shahmishal
approved these changes
Jul 6, 2021
|
Build failed |
|
@swift-ci please build toolchain |
|
@swift-ci please smoke test macOS |
|
@swift-ci please test macOS |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic could fail silently to copy the library if the i386
slice is not present in the first place (like it is the case for
libclang_rt.tvos.ain Xcode 13.0 beta 1) -- this will avoid errorslike
This is a backport of #38262
Addresses rdar://80209915