[rebranch] Include <climits> in Ownership.h
#38277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to address the following failure in Linux ``` /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test@2/branch-rebranch/swift/include/swift/AST/ReferenceStorage.def:189:1: error: use of undeclared identifier 'INT_MIN' ```
|
@swift-ci please smoke test |
|
error: no member named 'PrintHelp' in 'llvm::opt::OptTable'; did you mean 'printHelp'? -- #38182 |
etcwilde
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
Huh, I'm trying to figure out how this compiled in the first place now.
This will work to get things moving for now. I would prefer staying consistent with C vs C++ header includes and using limits.h instead of climits.
Really though, replacing the INT_MIN with something like std::numeric_limits<int>::min() would be more C++-y though more verbose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address the following failure in Linux