[5.5][Diagnostics] Ignore result type failures if one side is a hole #38278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please clean test |
If one of the sides in a application result conversion is a hole it could only mean that the fix has been recorded earlier (at the point where hole was introduced) and failure at function result position could be safely ignored. Resolves: rdar://79757320
|
@swift-ci please clean test |
|
@swift-ci please nominate |
airspeedswift
approved these changes
Jul 8, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #38235
Fixes a situation where the type-checker failed to produce a diagnostic.
If one of the sides in a application result conversion is a hole
it could only mean that the fix has been recorded earlier (at the
point where hole was introduced) and failure at function result
position could be safely ignored.
Scope: Incorrect calls where result cannot be inferred and contextual type is represented by a dependent member type.
Main Branch PR: [Diagnostics] Ignore result type failures if one side is a hole #38235
Resolves: rdar://79757320
Risk: Low
Reviewed By: @hborla
Testing: Regression tests added to the suite
Resolves: rdar://79757320