[semantic-arc] Ignore type dependent uses when using a worklist to check for writes. #38301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck for writes. Otherwise, we hit misc crashes. The worklist should have always been filtering these. I wonder why we have never hit this issue before. I added a new API that filters out type dependent uses called ValueBase::getNonTypeDependentUses() to make it easier to perform def->use worklist traversal ignoring these uses. This mirrors the APIs that we have created for filtering type dependent operands when performing use->def worklist traversal. I also noticed that we are not eliminating a load [copy] that we could in the test case. I am going to file a separate bug report for that work. rdar://79781943
|
@swift-ci test |
meg-gupta
reviewed
Jul 7, 2021
|
@gottesmm LGTM. Thanks for clarifying about type dependent uses. |
|
No problem! 5.5 cherry-pick incoming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we hit misc crashes. The worklist should have always been filtering
these. I wonder why we have never hit this issue before.
I added a new API that filters out type dependent uses called
ValueBase::getNonTypeDependentUses() to make it easier to perform def->use
worklist traversal ignoring these uses. This mirrors the APIs that we have
created for filtering type dependent operands when performing use->def worklist
traversal.
I also noticed that we are not eliminating a load [copy] that we could in the
test case. I am going to file a separate bug report for that work.
rdar://79781943