Skip to content

ClosureLifetimeFixup: fix a crash due to an iterator invalidation problem. #38308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

eeckstein
Copy link
Contributor

The fix is the use the InstructionDeleter to iterate over (the not yet deleted) instructions in a block.

rdar://80093482

eeckstein added 2 commits July 8, 2021 15:29
… instructions.

the SSA updater replaces branch instructions when adding phi arguments. For deleting the old instruction use the InstructionDeleter utility.
…blem.

The fix is the use the InstructionDeleter to iterate over (the not yet deleted) instructions in a block.

rdar://80093482
@eeckstein eeckstein requested review from gottesmm and atrick July 8, 2021 13:50
@eeckstein
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Jul 8, 2021

Build failed
Swift Test OS X Platform
Git Sha - 3c0d8a6

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- thanks

@eeckstein
Copy link
Contributor Author

@swift-ci test macOS

1 similar comment
@eeckstein
Copy link
Contributor Author

@swift-ci test macOS

@eeckstein eeckstein merged commit 1c71091 into swiftlang:main Jul 9, 2021
@eeckstein eeckstein deleted the fix-closure-lifetime-fixup branch July 9, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants