Implement a custom Data.Iterator #3831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ptr[i] = UInt8(i % 23) | ||
| } | ||
| } | ||
| checkSequence(data, (0..<65535).lazy.map({ UInt8($0 % 23) })) |
There was a problem hiding this comment.
Please use two spaces for indentation unless the file already uses 4.
|
@swift-ci Please test |
|
LGTM, but deferring to @parkera to approve once CI passes. |
| ptr[i] = UInt8(i % 23) | ||
| } | ||
| } | ||
| checkSequence(data, (0..<65535).lazy.map({ UInt8($0 % 23) })) |
There was a problem hiding this comment.
One more thing: the expected value is the first parameter, sequence under test is the second.
public func checkSequence<
${genericParam}, S : Sequence
>(
_ expected: ${Expected},
_ sequence: S,
We should probably add argument labels to this function.
There was a problem hiding this comment.
Oops. That's a pretty important distinction.
|
Great idea, thanks @kballard . |
This iterator uses an inline 32-byte buffer so it doesn't have to call copyBytes(to:count:) for every single byte. It results in an approximate 6x speedup on my computer.
|
@swift-ci Please test |
|
Tests passed, CI failed for other reasons. |
|
Reverted in #3848: |
|
D'oh. Why didn't that fail with my local build? |
|
@kballard Because we just changed what |
1 task
|
Re-submitted as #3849. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Implement a custom
Data.Iteratorinstead of using the defaultIndexingIterator. This custom iterator uses an internal 32-byte buffer so it doesn't have to callcopyBytes(to:count:)as often. This results in an approximate 6x speedup on my computer.With the included benchmark, I get the following numbers with
IndexingIterator:And the following numbers with the custom iterator:
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.