[SE-0304] Align Task API implementation with the fourth revision of the proposal #38325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this as a staged change to the ABI, introducing an underscored `@usableFromInline` implementation to the ABI that we can rely on later, and an `@_alwaysEmitIntoClient` version we can inline now.
The prior implementation of `Task.sleep()` effectively had two different atomic words to capture the state, which could lead to cases where cancelling before a sleep operation started would fail to throw `CancellationError`. Reimplement the logic for the cancellable sleep with a more traditional lock-free approach by packing all of the state information into a single word, where we always load, figure out what to do, then compare-and-swap.
|
@swift-ci please test |
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Task API changes to align the implementation with the fourth revision of the SE-0304 "Structured Concurrency. Most of the changes are superficial (e.g., renames, trivial additions) and have no ABI impact. The addition of cancellable
Task.sleep(nanoseconds:)is a bit more involved because there's some subtle atomics manipulations going on, but the changes are limited to new API.Scope: Affects programs that use Swift Concurrency. They'll get new "deprecation" warnings to help them move to the new APIs.
Radar/SR Issue: rdar://80339563
Risk: Low.
Testing: PR testing and CI on main.
Original PR: #38306