Sema: Check conditional availability earlier in conformance checking [5.5] #38340
+71
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would only check conditional availability once we had committed to a best witness. Instead, let's use this information to disambiguate among multiple best witnesses, if we have them. Access control and unconditional unavailability are still only checked once the witness is chosen. Fixes rdar://problem/77259046.
slavapestov
force-pushed
the
conformance-checker-disambiguate-availability-5.5
branch
from
3e3f86f to
9bba346
Compare
DougGregor
approved these changes
Jul 9, 2021
|
@swift-ci please test |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would only check conditional availability once we had committed
to a best witness. Instead, let's use this information to disambiguate
among multiple best witnesses, if we have them.
Access control and unconditional unavailability are still only
checked once the witness is chosen.
Fixes rdar://problem/77259046.