[5.5][Diagnostics] Diagnose ambiguous solutions with warnings like regular ambiguities #38347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ambiguities If solutions either have no fixes at all or all of the are warnings, let's use `diagnoseAmbiguity` to diagnose such cases as-if there are no fixes at all. Resolves: rdar://79657350 (cherry picked from commit d1e1278)
|
@swift-ci please clean test |
|
Build failed |
|
@swift-ci please clean test Linux platform |
|
Build failed |
|
@swift-ci please test macOS platform |
|
@swift-ci please nominate |
DougGregor
approved these changes
Jul 13, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #38328
Fixes an issue in the solver where it would accept one of the solutions
for an ambiguous expression, which results in a crash later in the pipeline.
If solutions either have no fixes at all or all of them are warnings,
let's use
diagnoseAmbiguityto diagnose such cases as-if there areno fixes at all.
Scope: Ambiguous expressions where some of the solutions have warnings and others do not.
Main Branch PR: [Diagnostics] Diagnose ambiguous solutions with warnings like regular… #38328
Resolves: rdar://79657350
Risk: Low
Reviewed By: @hborla
Testing: Regression tests added to the suite
Resolves: rdar://79657350
(cherry picked from commit d1e1278)