C++ Interop: tweak subscript operator tests #38351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ structs that define a non-default copy constructor should actually copy their members in the copy constructor: Swift might copy the struct around, and if it does so after the `setValueAtIndex` call, the modification of `NonTrivialIntArrayByVal::values` won't propagate to the copied struct and these tests no longer pass: • `Interop/Cxx/operators/member-inline.swift` • `Interop/Cxx/operators/member-out-of-line.swift` The tests are currently passing on the main branch despite this, but they might fail after a seemingly unrelated change (which is how I discovered this).
|
@swift-ci please smoke test |
zoecarver
approved these changes
Jul 12, 2021
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ structs that define a non-default copy constructor should actually copy their members in the copy constructor:
Swift might copy the struct around, and if it does so after the
setValueAtIndexcall, the modification ofNonTrivialIntArrayByVal::valueswon't propagate to the copied struct and these tests no longer pass:•
Interop/Cxx/operators/member-inline.swift•
Interop/Cxx/operators/member-out-of-line.swiftThe tests are currently passing on the main branch despite this, but they might fail after a seemingly unrelated change (which is how I discovered this).