[SR-14761] Improve diagnostic for implicitly overridden init() #38365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Jul 13, 2021
Provide more detailed diagnostic message when implicitly synthesized @objc initializer in subclass was overridden inside the subclass' extension Resolves: rdar://problem/79179597
HannaYakusevych
force-pushed
the
fix-diagnostic-implicitly-overriden-init
branch
from
d23bb3e to
c0ea9b2
Compare
|
Looks good @swift-ci smoke test |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please clean smoke test Linux platform |
1 similar comment
|
@swift-ci please clean smoke test Linux platform |
xedin
changed the title
|
@swift-ci please clean smoke test Linux platform |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide more detailed diagnostic message when implicitly synthesized @objc initializer in subclass was overridden inside the subclass' extension
Resolves SR-14761