[TBDGen] Use default kind for AFPAST SILDeclRef. #38372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
When adding an AsyncFunctionPointer to the TBD, a LinkEntity of kind AsyncFunctionPointerAST is constructed containing the decl. That decl is then wrapped in a SILDeclRef which is then mangled. Previously, the kind of the SILDeclRef was erroneously forced to be Func. The result was a failure to mangle the TBD symbol for async constructors correctly. Here, that argument is omitted so that the kind can be determined appropriately by SILDeclRef's constructor. rdar://80485869
nate-chandler
force-pushed
the
rdar80485869
branch
from
19eb223 to
a9e6efb
Compare
|
@swift-ci please test |
|
@swift-ci please clean test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding an AsyncFunctionPointer to the TBD, a LinkEntity of kind AsyncFunctionPointerAST is constructed containing the decl. That decl is then wrapped in a SILDeclRef which is then mangled.
Previously, the kind of the SILDeclRef was erroneously forced to be Func. The result was a failure to mangle the TBD symbol for async constructors correctly.
Here, that argument is omitted so that the kind can be determined appropriately by SILDeclRef's constructor.
rdar://80485869