Skip to content

Add #unavailable to the changelog #38390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2021
Merged

Conversation

rockbruno
Copy link
Contributor

CHANGELOG.md Outdated
----------
* [SE-0290][]:

It is now possible to write inverted availability statements by using the new `#unavailable` keyword:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @amartini51 @beccadax is "keyword" the correct terminology here or should it be something else?

For example, https://forums.swift.org/t/concise-magic-file-names/31297 uses "magic identifier" to describe #file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling #unavailable a keyword matches #available, which we include in the list of keywords here:

https://docs.swift.org/swift-book/ReferenceManual/LexicalStructure.html#ID413

Copy link
Contributor

@varungandhi-apple varungandhi-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the point about "keyword". Thanks!

CHANGELOG.md Outdated
// Old functionality
} else {
// iOS 15 functionality
}```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These backticks should be on the next line.

Previous sections also end with the following reminder:

**Add new entries to the top of this section, not here!**

@varungandhi-apple
Copy link
Contributor

@swift-ci smoke test

@varungandhi-apple varungandhi-apple merged commit 77dfb64 into swiftlang:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants