-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add #unavailable to the changelog #38390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CHANGELOG.md
Outdated
---------- | ||
* [SE-0290][]: | ||
|
||
It is now possible to write inverted availability statements by using the new `#unavailable` keyword: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @amartini51 @beccadax is "keyword" the correct terminology here or should it be something else?
For example, https://forums.swift.org/t/concise-magic-file-names/31297 uses "magic identifier" to describe #file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
availability statements
→ availability conditions
https://docs.swift.org/swift-book/ReferenceManual/Statements.html#ID522
https://docs.swift.org/swift-book/LanguageGuide/ControlFlow.html#ID523
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling #unavailable
a keyword matches #available
, which we include in the list of keywords here:
https://docs.swift.org/swift-book/ReferenceManual/LexicalStructure.html#ID413
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the point about "keyword". Thanks!
CHANGELOG.md
Outdated
// Old functionality | ||
} else { | ||
// iOS 15 functionality | ||
}``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These backticks should be on the next line.
Previous sections also end with the following reminder:
**Add new entries to the top of this section, not here!**
Co-authored-by: Alex Martini <[email protected]>
@swift-ci smoke test |
#33932