Add support for opaque result types in structural positions #38392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not ready to merge yet, but considering its size it might be worth doing some code review now. |
willtunnels
force-pushed
the
structural-some-types
branch
from
fc33fce to
bced7d6
Compare
willtunnels
force-pushed
the
structural-some-types
branch
from
45af428 to
7fabab8
Compare
xedin
reviewed
Jul 22, 2021
slavapestov
approved these changes
Jul 27, 2021
willtunnels
force-pushed
the
structural-some-types
branch
from
abe5600 to
c77d8ba
Compare
hborla
approved these changes
Aug 3, 2021
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only support opaque result types as top level level types, e.g.
some Pis allowed but not(some P)?. This branch adds support for opaque result types in structural type positions.