-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[SourceKit/DocInfo] Add is_async for properties with async getters #38401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
Build failed |
@swift-ci please clean test Linux platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Would it also be worth adding a test case for the imported Obj-C method as async
property case?
0ff61bb
to
d493381
Compare
Eh, I figured that we have tests for the importer already so they seemed unnecessary. But it can't hurt, so I've added one anyway (and for the regular function import). @swift-ci please test |
Build failed |
@swift-ci please clean test Linux platform |
Build failed |
Resolves rdar://80546521
d493381
to
f9b3e40
Compare
I suppose it would help if I actually added the new files 🤦 @swift-ci please test |
Build failed |
Build failed |
@swift-ci please test Linux platform |
Build failed |
@swift-ci please clean test Linux platform |
Build failed |
@swift-ci please clean test Linux platform |
Thanks for re-running @artemcm! |
Resolves rdar://80546521