Skip to content

[SourceKit/DocInfo] Add is_async for properties with async getters #38401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

bnbarham
Copy link
Contributor

Resolves rdar://80546521

@bnbarham bnbarham requested review from akyrtzi and hamishknight July 15, 2021 05:19
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0ff61bb95cad430cfac51a8caa95b99363bda6ab

@bnbarham
Copy link
Contributor Author

@swift-ci please clean test Linux platform

Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would it also be worth adding a test case for the imported Obj-C method as async property case?

@bnbarham bnbarham force-pushed the add-is-async-to-properties branch from 0ff61bb to d493381 Compare July 16, 2021 00:10
@bnbarham
Copy link
Contributor Author

LGTM! Would it also be worth adding a test case for the imported Obj-C method as async property case?

Eh, I figured that we have tests for the importer already so they seemed unnecessary. But it can't hurt, so I've added one anyway (and for the regular function import).

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - d4933817c70fe916f6e9ae5d24cf993788b46179

@bnbarham
Copy link
Contributor Author

@swift-ci please clean test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d4933817c70fe916f6e9ae5d24cf993788b46179

@bnbarham bnbarham force-pushed the add-is-async-to-properties branch from d493381 to f9b3e40 Compare July 16, 2021 03:36
@bnbarham
Copy link
Contributor Author

I suppose it would help if I actually added the new files 🤦

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - d4933817c70fe916f6e9ae5d24cf993788b46179

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f9b3e40

@bnbarham
Copy link
Contributor Author

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f9b3e40

@bnbarham
Copy link
Contributor Author

@swift-ci please clean test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f9b3e40

@artemcm
Copy link
Contributor

artemcm commented Jul 16, 2021

@swift-ci please clean test Linux platform

@bnbarham
Copy link
Contributor Author

Thanks for re-running @artemcm!

@bnbarham bnbarham merged commit 92c336c into swiftlang:main Jul 16, 2021
@bnbarham bnbarham deleted the add-is-async-to-properties branch July 16, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants