Lift Requirement and Parameter Accessors up to GenericSignature #38403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slavapestov Here's that refactoring I promised you last year |
|
Build failed |
|
Build failed |
|
@swift-ci smoke test |
|
Build failed |
|
Build failed |
CodaFi
force-pushed
the
sigarillo
branch
2 times, most recently
from
4cfe07b to
5da823a
Compare
|
Build failed |
|
Build failed |
|
Build failed |
|
@swift-ci smoke test |
Start treating the null {Can}GenericSignature as a regular signature
with no requirements and no parameters. This not only makes for a much
safer abstraction, but allows us to simplify a lot of the clients of
GenericSignature that would previously have to check for null before
using the abstraction.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start depopulating GenericSignatureImpl by treating null {Can}GenericSignatures as signatures with no requirements and no parameters. There are intervening commits with the results of a manual pass through the existing callers of these functions to see where we could simplify some uses. I'm sure there are many more that I've missed.