[Concurrency] prevent races in task cancellation #38404
Conversation
ktoso
force-pushed
the
wip-task-cancellation-double
branch
from
6790157 to
64f13ed
Compare
ktoso
force-pushed
the
wip-task-cancellation-double
branch
2 times, most recently
from
be19b86 to
5dec799
Compare
|
@swift-ci please smoke test |
|
Windows |
ktoso
force-pushed
the
wip-task-cancellation-double
branch
2 times, most recently
from
8d30552 to
9d5be78
Compare
ktoso
force-pushed
the
wip-task-cancellation-double
branch
from
9d5be78 to
e8888f7
Compare
|
@swift-ci please smoke test and merge |
| void run(JobPriority newPriority) { | ||
| Function(Argument, newPriority); | ||
| } | ||
| void run(JobPriority newPriority) { Function(Argument, newPriority); } | ||
|
|
There was a problem hiding this comment.
(The formatting changes are by git-clang-format)
|
|
||
| // else, the task was already cancelled, so while the record was added, | ||
| // we must run it immediately here since no other task will trigger it. | ||
| record->run(); |
There was a problem hiding this comment.
The change™.
We used to do this in a racy way in Swift but have to do so in here, based on the return of addStatusRecord
ktoso
added
the
concurrency
|
It's a bit unfortunate that this PR has a ton of unrelated reformatting in it. |
|
Otherwise the fix looks good, thanks! |
|
Thanks for review!
Yeah... :| Perhaps I misused git-clang-format? Only discovered it this week to be honest heh; maybe I had applied it to the wrong commit...? I'll double check next time if it did the right thing, I kind of want it as a post-commit hook hmmm |
This fixes two kinds of races with withTaskCancellationHandler:
Many details inside the PR.
Resolves rdar://78177513