[Syntax] Make PostfixIfConfigExpr.base optional
#38410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift-syntax#297 |
allevato
approved these changes
Jul 15, 2021
| #if true | ||
| .call() | ||
| #else | ||
| #if true |
There was a problem hiding this comment.
Would it be worth having another case where there is an intervening member access expression in the middle of two clauses, to check that the base is present in that nesting scenario? For example,
foo()
#if COND1
.bar?()!
#elseif COND2
#if true
.call()
#else
.somethingElse
#if true
...
For nested `#if ... #endf` in postfix if-config expression, like:
baseExpr
#if COND1
#if COND2
.member
#endif
#endif
Consider the inner `#if` be a postfix if-config with 'nil' base
expression.
https://bugs.swift.org/browse/SR-14929
rintaro
force-pushed
the
syntax-postfixifconfig-sr14929
branch
from
3fccf51 to
b455177
Compare
|
swiftlang/swift-syntax#297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For nested
#if ... #endfin postfix if-config expression, like:baseExpr #if COND1 #if COND2 .member #endif #endifConsider the inner
#ifbe a postfix if-config expression with a 'nil' base expression.https://bugs.swift.org/browse/SR-14929
rdar://80688328