fix parsing of isolated as an argument label
#38422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
added
bug
|
@swift-ci please smoke test |
kavon
force-pushed
the
isolated-argument-label
branch
from
3c91a64 to
0d01a37
Compare
With the introduction of `isolated` as a type modifier for actor types, the parsing of a parameter regressed such that `isolated` was no longer accepted as an ordinary argument label. This patch fixes that and adds a little lookahead utility to clean-up the code that disambiguates the uses of `isolated` as either a label or a type modifier. Resolves rdar://80300022
kavon
force-pushed
the
isolated-argument-label
branch
from
0d01a37 to
5ffe8e0
Compare
|
@swift-ci please smoke test |
ktoso
approved these changes
Jul 16, 2021
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of
isolatedasa type modifier for actor types, the
parsing of a parameter regressed such
that
isolatedwas no longer acceptedas an ordinary argument label. This patch
fixes that and adds a little lookahead
utility to clean-up the code that
disambiguates the uses of
isolatedas either a label or a type modifier.
Resolves rdar://80300022