Skip to content

[5.5] Further workaround for priority mishandling in runtime. #38428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2021
Merged

[5.5] Further workaround for priority mishandling in runtime. #38428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion stdlib/public/Concurrency/Task.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,12 @@ static AsyncTaskAndContext swift_task_create_commonImpl(
if (currentTask)
jobFlags.setPriority(currentTask->getPriority());
else
jobFlags.setPriority(swift_task_getCurrentThreadPriority());
// FIXME: Ideally, this should be setting priority based on
// swift_task_getCurrentThreadPriority(). However, that creates
// priority differences which lead to different kinds of hangs
// Temporarily use Unspecified to work around that.
// See also: PR #37939.
jobFlags.setPriority(JobPriority::Unspecified);
}

// Figure out the size of the header.
Expand Down