[5.5][runtime] Improve detection of memory allocation failures #38452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `posix_memalign` doesn't write to its pointer-to-pointer parameter when it fails, so `AlignedAlloc` ended up returning stack detritus in that case. The variable is now properly initialized in order to avoid that. - update documentation of UMR[B]P.allocate()
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
kylemacomber
approved these changes
Jul 20, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
posix_memaligndoesn't write to its pointer-to-pointer parameter when it fails, soAlignedAllocended up returning stack detritus in that case. The variable is now properly initialized in order to avoid that.update documentation of
UMRP.allocate()to specify the requirement for powers-of-2 alignment.update documentation fo
UMRBP.allocate()to be as good asUMRP's version.Resolves rdar://80504684 and rdar://79314903
Cherry-picked from #38424