[IDE] Fix another GenericFunctionType subst crasher #38503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were defaulting to the method's interface type, which could lead to calling `subst` with a GenericFunctionType. Instead, pass the result type only, as that's all we want anyway. rdar://77259607
Remove the default argument for the `memberType` parameter and enforce that GenericFunctionType is not passed. Also add a defaulted overload for the property case, as they should never have a GenericFunctionType interface type.
hamishknight
force-pushed
the
another-one-bites-the-subst
branch
from
4586b12 to
d4c25f5
Compare
slavapestov
approved these changes
Jul 20, 2021
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
rintaro
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When matching methods for the conforming types SourceKit request, we were using the method's interface type in a call to
TypeBase::getTypeOfMember, which could lead to crashes when callingsubstwith a GenericFunctionType. Instead, pass the result type only, as that's all we want anyway.Then change
TypeBase::getTypeOfMemberto enforce that a GenericFunctionType isn't passed as thememberTypeparameter to avoid other callers making the same mistake.rdar://77259607