[AST] Add some factory constructors #38504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
construction-site
branch
from
0cc0e99 to
2ef56cf
Compare
hamishknight
force-pushed
the
construction-site
branch
from
2ef56cf to
088d876
Compare
Add a convenience constructor for an implicit nullary call. This will become more useful when the argument parameter starts taking an ArgumentList.
This provides consistency with other AST nodes, and will be useful for implementing ArgumentList construction in the future.
Introduce private constructors for specific kinds of components, leaving the subscript constructor to deal with only subscripts.
Explicitly call out the fact we're dealing with tuples.
hamishknight
force-pushed
the
construction-site
branch
from
088d876 to
df566e3
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off a couple of separate changes from #37435