Stage the swift_continuation_await ABI change #38528
Merged
+75
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a fake (but non-ABI) declaration to the swiftinterface which marks that an SDK support swift_continuation_await, and then only call it if that declaration exists, otherwise falling back on the old atomic sequence. Using that sequence will badly mess up the runtime's tracking of task state, but it might still work, and more importantly things will still build, which solves the short-term problem. Hopefully we can remove this hack soon. Fixes rdar://problem/80787731.
|
@swift-ci Please test |
DougGregor
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a fake (but non-ABI) declaration to the swiftinterface which marks that an SDK support
swift_continuation_await, and then only call it if that declaration exists, otherwise falling back on the old atomic sequence. Using that sequence will badly mess up the runtime's tracking of task state, but it might still work, and more importantly things will still build, which solves the short-term problem. Hopefully we can remove this hack soon.Fixes rdar://problem/80787731.
My testing of this involved manually editing the swiftinterface and deleting the swiftmodule; I can't think of a reasonable way to test it automatically.