SE-0103 Noescape by default #3853

milseman · 2016-07-29T04:50:10Z

What's in this pull request?

[noescape by defaul] make noescape the default

This makes @noescape be the default semantics for
function types in argument positions, for everything except property
setters. Property setters are naturally escaping, so they keep their
escaping-by-default behavior.

There is some further (non-source-breaking) work to be done for
SE-0103:

- We need the withoutActuallyEscaping function
- Improve diagnostics and QoI to at least @noescape's standards
- Deprecate / drop @noescape, right now we allow it
- Update internal code completion printing to be contextual
- Add more tests to explore tricky corner cases
- Small regressions in fixits in attr/attr_availability.swift
- Use @autoclosure @escaping instead of @autoclosure(escaping)

Resolved bug number: (SR-1952)

Before merging this pull request to apple/swift repository:

Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform	Comment
All supported platforms	@swift-ci Please smoke test
All supported platforms	@swift-ci Please smoke test and merge
OS X platform	@swift-ci Please smoke test OS X platform
Linux platform	@swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

Builds the compiler incrementally.
Builds the standard library only for macOS. Simulator standard libraries and
device standard libraries are not built.
lldb is not built.
The test and validation-test targets are run only for macOS. The optimized
version of these tests are not run.

A smoke test on Linux does the following:

Builds the compiler incrementally.
Builds the standard library incrementally.
lldb is built incrementally.
The swift test and validation-test targets are run. The optimized version of these
tests are not run.
lldb is tested.

Validation Testing

Platform	Comment
All supported platforms	@swift-ci Please test
All supported platforms	@swift-ci Please test and merge
OS X platform	@swift-ci Please test OS X platform
OS X platform	@swift-ci Please benchmark
Linux platform	@swift-ci Please test Linux platform

Lint Testing

Language	Comment
Python	@swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

milseman · 2016-07-29T04:50:53Z

@swift-ci please test

milseman · 2016-07-29T04:51:30Z

There might be some gtest failures, which I didn't see originally but I see locally after rebasing. But, this should be close and I'll try to fix those if they repro on the bots.

lattner · 2016-07-29T05:49:56Z

Awesome, thank you for working on this!

gribozavr · 2016-07-29T08:18:59Z

test/IDE/complete_override.swift

@@ -463,7 +463,8 @@ class TestClassWithThrows : HasThrowing, HasThrowingProtocol {
 // HAS_THROWING: Begin completions
 // HAS_THROWING-DAG: Decl[InstanceMethod]/Super:         func foo() throws {|}; name=foo() throws
 // HAS_THROWING-DAG: Decl[InstanceMethod]/Super:         override func bar() throws {|}; name=bar() throws
-// HAS_THROWING-DAG: Decl[InstanceMethod]/Super:         override func baz(x: () throws -> ()) rethrows {|}; name=baz(x: () throws -> ()) rethrows
+// FIXME: make the below require to print @escaping


Issue & radar?

gribozavr · 2016-07-29T08:21:44Z

Library changes and changes to library tests LGTM.

milseman · 2016-07-29T17:55:07Z

@swift-ci please smoke test

milseman · 2016-07-29T17:56:43Z

I fixed up the benchmarks and applied feedback. Unfortunately, I'm not sure about the corelibs-foundation failures. I'll try to fix them up blind in swiftlang/swift-corelibs-foundation#492

tanadeau · 2016-07-29T17:58:19Z

Another item on the TODO list would be to change @autoclosure(escaping) to @autoclosure @escaping.

milseman · 2016-07-29T18:29:32Z

Linux failures are corelibs-foundtaion, which I'll be fixing soon.

@NoEscape

Emits the error and fixit on parameter @NoEscape to move it to the type, even if the type itself is also correctly attributed as @NoEscape. This will become important when @NoEscape is the default to keep our nice and friendly fixits.

@NoEscape

Changes diangostic messages from referring specifically to @NoEscape, which is going away, to 'non-escaping'. Introduces better diagnostics and fixits for adding @escaping to closures that escape.

The isExplicitlyEscaping bit, though useful for printing, unfortunately puts us in a position where we have different bit patterns for the same type, and thus lose much of our type equivalence checking for overriding, protocol conformance, etc., even if we were to take subtyping into account. We need to drop it, relying on the existing noescape bit alone to determine the type's semantics (at least, as long as we continue to encode this information in the type system). This is a partial fix; we will now be excessively printing @escaping, but the subsequent commits will correct this. For printing, we will instead need to be more context-aware.

Adds an explicit @escaping throughout the standard library, validation test suite, and tests. This will be necessary as soon as noescape is the default for closure parameters.

@NoEscape

This flips the switch to have @NoEscape be the default semantics for function types in argument positions, for everything except property setters. Property setters are naturally escaping, so they keep their escaping-by-default behavior. Adds contentual printing, and updates the test cases. There is some further (non-source-breaking) work to be done for SE-0103: - We need the withoutActuallyEscaping function - Improve diagnostics and QoI to at least @NoEscape's standards - Deprecate / drop @NoEscape, right now we allow it - Update internal code completion printing to be contextual - Add more tests to explore tricky corner cases - Small regressions in fixits in attr/attr_availability.swift

Adds @escaping to internal benchmark code to fix it. References SR for known limitation. Use stdlib coding style for arguments.

milseman · 2016-07-29T21:55:13Z

And XCTest update: swiftlang/swift-corelibs-xctest#146

milseman · 2016-07-29T22:26:45Z

Validation tests pass for me with those PRs on Linux. OS X already passed. I'll have to watch CI carefully.

…efault" This reverts commit 8219d4f, reversing changes made to e37d048.

jessesquires mentioned this pull request Jul 29, 2016

Issue 33 - after Swift 3 SwiftWeekly/swiftweekly.github.io#57

Closed

gribozavr reviewed Jul 29, 2016
View reviewed changes

milseman added 6 commits July 29, 2016 13:48

[noescape by default] Improve and introduce diagnostics

2bb3347

Changes diangostic messages from referring specifically to @NoEscape, which is going away, to 'non-escaping'. Introduces better diagnostics and fixits for adding @escaping to closures that escape.

[noescape by default] Proliferate @escaping

ccda8f3

Adds an explicit @escaping throughout the standard library, validation test suite, and tests. This will be necessary as soon as noescape is the default for closure parameters.

[noescape by default] Fix benchmarks and incorporate feedback

25ac879

Adds @escaping to internal benchmark code to fix it. References SR for known limitation. Use stdlib coding style for arguments.

milseman force-pushed the noescape_by_default branch from 71a911f to 25ac879 Compare July 29, 2016 20:49

milseman assigned tkremenek Jul 29, 2016

DougGregor merged commit 8219d4f into swiftlang:master Jul 29, 2016

milseman added a commit to milseman/swift that referenced this pull request Jul 29, 2016

Revert "Merge pull request swiftlang#3853 from milseman/noescape_by_d…

31fa694

…efault" This reverts commit 8219d4f, reversing changes made to e37d048.

jessesquires mentioned this pull request Aug 4, 2016

Update status for SE-0101, SE-0103, SE-0117 swiftlang/swift-evolution#487

Merged

milseman mannequin mentioned this pull request Jul 29, 2016

[SR-1952] Implement SE-0103: Make non-escaping closures the default #44561

Closed

milseman mannequin mentioned this pull request Feb 6, 2023

[SR-2214] Internal code completion should print @escaping #44821

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SE-0103 Noescape by default #3853

SE-0103 Noescape by default #3853

Uh oh!

milseman commented Jul 29, 2016 •

edited

Loading

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

lattner commented Jul 29, 2016

Uh oh!

gribozavr Jul 29, 2016

Uh oh!

gribozavr commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

tanadeau commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

Uh oh!

SE-0103 Noescape by default #3853

SE-0103 Noescape by default #3853

Uh oh!

Conversation

milseman commented Jul 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's in this pull request?

Resolved bug number: (SR-1952)

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

lattner commented Jul 29, 2016

Uh oh!

gribozavr Jul 29, 2016

Choose a reason for hiding this comment

Uh oh!

gribozavr commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

tanadeau commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

milseman commented Jul 29, 2016

Uh oh!

Uh oh!

milseman commented Jul 29, 2016 •

edited

Loading