Sema: Fix bogus 'parameters may not have the 'var' specifier' diagnostic #3855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
| @@ -288,6 +288,11 @@ class alignas(1 << DeclAlignInBits) Decl { | |||
| /// once (either in its declaration, or once later), making it immutable. | |||
| unsigned IsLet : 1; | |||
|
|
|||
| /// \brief Whether this is an 'inout' parameter; this is preferrable | |||
If an inout parameter has an invalid type, we were unable to distinguish it from a 'var' parameter, resulting in an invalid diagnostic. Fix this by adding a VarDecl::isInOut() flag, instead of introspecting the type.
slavapestov
force-pushed
the
fix-bad-diagnostic
branch
from
bb92905 to
9a1fa52
Compare
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small regression with Swift 3 language changes.