[Concurrency] Remove libatomic dependency on Concurrency module on Linux #38551
Conversation
|
@swift-ci test |
|
@swift-ci Please test Ubuntu 20.04 platform |
|
@swift-ci Please test Ubuntu 18.04 platform |
|
@swift-ci Please test CentOS 7 platform |
|
@swift-ci Please test CentOS 8 platform |
|
Build failed |
|
@swift-ci Please test Ubuntu 20.04 platform |
|
@swift-ci test Amazon Linux 2 |
|
Build failed |
|
@swift-ci test CentOS 8 |
| @@ -159,7 +159,7 @@ class TaskFutureWaitAsyncContext : public AsyncContext { | |||
| } // end anonymous namespace | |||
|
|
|||
| /// The current state of a task's status records. | |||
| class ActiveTaskStatus { | |||
| class alignas(sizeof(void*) * 2) ActiveTaskStatus { | |||
There was a problem hiding this comment.
Do you want to use sizeof(uintptr_t) to make the intent clearer?
There was a problem hiding this comment.
We use void* in other places, so I wanted to keep it consistent.
| @@ -33,8 +33,7 @@ endif() | |||
| # Frustratingly, in many cases this isn't necessary because the | |||
| # sequence is inlined, but we have some code that's just subtle | |||
| # enough to turn into runtime calls. | |||
| if(SWIFT_HOST_VARIANT STREQUAL "linux" OR | |||
| SWIFT_HOST_VARIANT STREQUAL "android") | |||
| if(SWIFT_HOST_VARIANT STREQUAL "android") | |||
There was a problem hiding this comment.
This has not been tried on Android, I simply asked that it be added in #38508 since usually it will be needed if it is on linux. If you don't need this on linux after your change, just revert that patch instead, ie remove it for Android too.
|
Whoo, great to see more linux distros added to the CI. |
|
Build failed |
|
@buttaface the distros have been there since we started supporting them, you just have to manually trigger the build, since it would be overkill to build all of them on every PR. |
|
@swift-ci clean test CentOS 8 |
No description provided.