Fix arg cleanup for objc continuations #38556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
meg-gupta
force-pushed
the
fixobjcasyncsilgen
branch
from
171ca1a to
3b739e2
Compare
|
@swift-ci test |
|
Build failed |
jckarter
reviewed
Jul 22, 2021
meg-gupta
force-pushed
the
fixobjcasyncsilgen
branch
3 times, most recently
from
39aff13 to
7224888
Compare
gottesmm
reviewed
Jul 22, 2021
|
@swift-ci test |
gottesmm
reviewed
Jul 22, 2021
meg-gupta
force-pushed
the
fixobjcasyncsilgen
branch
from
7224888 to
518e9da
Compare
gottesmm
reviewed
Jul 22, 2021
gottesmm
reviewed
Jul 22, 2021
gottesmm
reviewed
Jul 22, 2021
gottesmm
reviewed
Jul 22, 2021
gottesmm
reviewed
Jul 22, 2021
Current SILGen for objc continuations, can end the lifetime of args before await_async_continuation. This PR fixes it by extending the lifetime of the args until await_async_continuation by creating copies. And then inserts manual cleanup with fix_lifetime + destroy Fixes rdar://78982371
meg-gupta
force-pushed
the
fixobjcasyncsilgen
branch
from
518e9da to
3372ab7
Compare
|
@swift-ci test |
|
@jckarter does this version look okay ? |
|
LGTM, thanks @meg-gupta ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current SILGen for objc continuations, can end the lifetime of args
before await_async_continuation.
This PR fixes it so that the cleanups of args for such applies can be
delayed until result plan emission which generates
await_async_continuation.Also inserts fix_lifetime cleanup so that optimizer cannot move lifetime ending operations before
await_async_continuationFixes rdar://78982371