Skip to content

[Async Refactoring] Add parens around custom error cast #38583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

hamishknight
Copy link
Contributor

When passing a forwarded error to a CustomError? completion handler parameter, wrap the cast in a set of parentheses to silence a warning in the refactored code.

rdar://80409905

When passing a forwarded error to a CustomError?
completion handler parameter, wrap the cast in a
set of parentheses to silence a warning in the
refactored code.

rdar://80409905
@hamishknight
Copy link
Contributor Author

@swift-ci please smoke test

@hamishknight hamishknight requested a review from bnbarham July 22, 2021 22:23
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Hamish

@hamishknight hamishknight merged commit 5248388 into swiftlang:main Jul 23, 2021
@hamishknight hamishknight deleted the errors-as-warnings branch July 23, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants