[5.5] [Runtime] Resume to the generic executor in the absence of an override. #38601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, we saw a crash involving URLSession where we'd hit assertions or corruption in the runtime in various forms: - Assertion on trying to enqueue work onto a zombie actor. - job->SchedulerPrivate being overwritten (crash in getNextJobInQueue). - *(job->SchedulerPrivate) being overwritten (crash in getAsPreprocessedJob right after call to getNextJobInQueue). I haven't been able to create a minimal crashing example yet, but manual testing shows this does fix the issue. Fixes rdar://79859254. (cherry picked from commit d348fd9)
|
main PR: #38600 |
|
@swift-ci test |
|
Build failed |
|
@swift-ci test Linux |
DougGregor
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, we saw a crash involving URLSession where we'd hit
assertions or corruption in the runtime in various forms:
right after call to getNextJobInQueue).
I haven't been able to create a minimal crashing example yet, but manual
testing shows this does fix the issue.
Fixes rdar://79859254.
(cherry picked from commit d348fd9)