[5.5] Delete flaky tests and add back test coverage to other crasher tests #38608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
gottesmm
force-pushed
the
release/5.5-disable-flake
branch
from
405fbd5 to
15a4436
Compare
|
@swift-ci test |
gottesmm
changed the title
mikeash
approved these changes
Jul 23, 2021
|
@swift-ci nominate |
DougGregor
approved these changes
Jul 26, 2021
…leCheck tests since the FileCheck tests are too unstable given concurrency. I also migrated some of the tests (out of an abundance of caution) into the executable test cases.
gottesmm
force-pushed
the
release/5.5-disable-flake
branch
from
15a4436 to
4d9aa67
Compare
|
@swift-ci test |
|
Build failed |
|
@swift-ci test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am doing this specially for 5.5 in order to ensure that the bots do not hit
issues related to this.
NOTE: We already covered this explicitly with crash tests. That being
said, just for completeness/paranoia I am currently merging some literal
versions of these into main and will add them later. I just do not want to have
spurious failures on the bots.
CCC
Explanation: When I originally added these FileCheck tests, I thought they were stable... but after a day of testing on the bots, it is clear that they are not. This just deletes these tests so that the 5.5 bots are not hit by instability. There are already runtime based tests that test out the same things (using no-crash/crash cases).
Scope: Without this change, the 5.5 bots will fail sometime.
SR Issue: rdar://81031901
Risk: None. We are just removing flaky tests and added a few additional ones to ensure test coverage.
Testing: I added back some of the tests as appropriate.
Reviewer: @mikeash