[exclusivity] Split out of Exclusivity.cpp FunctionReplacement and the Global TLSContext. #38622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
|
@swift-ci test OS X platform |
|
Build failed |
aschwaighofer
approved these changes
Jul 26, 2021
|
@aschwaighofer just wanted you to be aware of it. |
…e Global TLSContext. Some notes: 1. Even though I refactored out AccessSet/Access from Exclusivity.cpp -> ExclusivityPrivate.h, I left the actual implementations of insert/remove in Exclusivity.cpp to allow for the most aggressive optimization for use in Exclusivity.cpp without exposing a bunch of internal details to other parts of the runtime. Smaller routines like getHead() and manipulating the linked list directly I left as methods that can be used by other parts of the runtime. I am going to use these methods to enable backwards deployment of exclusivity support for concurrency. 2. I moved function replacements out of the Exclusivity header/cpp files since it has nothing to do with Exclusivity beyond taking advantage of the TLS context that we are already using.
gottesmm
force-pushed
the
pr-6947135ffaebc2f84fcc96a081d32e9829585992
branch
from
ab117da to
3e64d03
Compare
|
@swift-ci test |
|
Figured out the problem. Needed some more includes for the simulator/etc. |
atrick
reviewed
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
Even though I refactored out AccessSet/Access from Exclusivity.cpp ->
ExclusivityPrivate.h, I left the actual implementations of insert/remove in
Exclusivity.cpp to allow for the most aggressive optimization for use in
Exclusivity.cpp without exposing a bunch of internal details to other parts of
the runtime. Smaller routines like getHead() and manipulating the linked list
directly I left as methods that can be used by other parts of the runtime. I am
going to use these methods to enable backwards deployment of exclusivity support
for concurrency.
I moved function replacements out of the Exclusivity header/cpp files since
it has nothing to do with Exclusivity beyond taking advantage of the TLS context
that we are already using.