[CS] Fix diagnostic fix-it paren handling #38631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owingOperator Such implicit tuples may be used to represent argument lists for e.g binary expressions, and as such shouldn't be considered as parent exprs that satisfy the role of parentheses. Also fix the callers to use the raw anchor as the root expression they pass to provide an accurate parent map. This requires sinking the UnresolvedMemberChainResultExpr handling logic into `getPrecedenceParentAndIndex`. rdar://81109287
|
@swift-ci please test |
xedin
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't consider implicit TupleExprs in
exprNeedsParensOutsideFollowingOperator, as such implicit tuples may be used to represent argument lists for e.g binary expressions, and as such shouldn't be considered as parent exprs that satisfy the role of parentheses.Also fix the callers to use the raw anchor as the root expression they pass to provide an accurate parent map. This requires sinking the UnresolvedMemberChainResultExpr handling logic into
getPrecedenceParentAndIndex.rdar://81109287