[Frontend] Always output the version being compiled for #38641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outputting the effective version in the pretty stack trace was skipped if the current version was the same as the effective version. This would result in an empty line, which is somewhat confusing. Output a line regardless. Resolves rdar://81140703
bnbarham
commented
Jul 27, 2021
| @@ -16,6 +16,10 @@ | |||
| // CHECK-ALLOW: Program arguments: {{.*}} -experimental-allow-module-with-compiler-errors | |||
| // CHECK-ALLOW: Compiling with effective version | |||
|
|
|||
| // RUN: not --crash %target-swift-frontend -typecheck -debug-crash-after-parse -experimental-allow-module-with-compiler-errors -swift-version 5 %s 2>&1 | %FileCheck -check-prefix CHECK-CURRENT %s | |||
There was a problem hiding this comment.
This is a little annoying since we'll have to update this when the major version changes, but unfortunately -swift-version 4 is included in the test options. Do you have any better ideas here @xymus?
There was a problem hiding this comment.
Hum, yeah, that automatic -swift-version 4 is unfortunate. We don't update the language version that often, I think this is fine.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outputting the effective version in the pretty stack trace was skipped
if the current version was the same as the effective version. This would
result in an empty line, which is somewhat confusing. Output a line
regardless.
Resolves rdar://81140703