Skip to content

[test] Add test for inout arg in strange interpolation #38656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2021
Merged

[test] Add test for inout arg in strange interpolation #38656

merged 1 commit into from
Jul 28, 2021

Conversation

hamishknight
Copy link
Contributor

Just to make sure #37435 continues to correctly handle it

@hamishknight
Copy link
Contributor Author

@swift-ci please smoke test

beccadax
beccadax approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, I don't think it would be a bad thing if we stopped emitting the warnings in the future and only emitted the errors, but it's better to have a test and change it when we expect a behavior change than to not have a test.

@hamishknight hamishknight merged commit 119e886 into swiftlang:main Jul 28, 2021
@hamishknight hamishknight deleted the up-for-interpolation branch July 28, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beccadax beccadax beccadax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishknight @beccadax