Skip to content

[ClangImporter] Add @available(*, renamed:) to imported async getters #38688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

bnbarham
Copy link
Contributor

The attribute was missing from functions with getters as their async
alternative. Only getters are imported like this, so no need to check
for the other accessors.

Resolves rdar://80612566

The attribute was missing from functions with getters as their async
alternative. Only getters are imported like this, so no need to check
for the other accessors.

Resolves rdar://80612566
@bnbarham bnbarham requested a review from etcwilde July 29, 2021 05:08
@bnbarham
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0389ea5

@bnbarham
Copy link
Contributor Author

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 0389ea5

@bnbarham
Copy link
Contributor Author

Failing test was disabled in another PR that's now merged

@swift-ci please test macOS platform

@bnbarham bnbarham merged commit 0ccf43d into main Jul 29, 2021
@bnbarham bnbarham deleted the add-available-to-getters branch July 29, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants