C++ Interop: fix ClangImporter/cxx_interop_ir.swift on 32-bit
#38692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
zoecarver
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Two things:
- make sure to close this SR when the PR lands.
- Please make sure a full test passes on macOS at least. The 32-bit tests aren't run during a smoke test, IIUC. In fact, if we have any IRGen tests in the future, we should probably do a full test of that PR (not just a smoke test).
|
@swift-ci please test macOS. |
Yes, that's reasonable. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failed test was discovered here: #38618 (comment).
Fixes SR-14986.