[Sema][CSSimplify] Account for synthesized args when diagnosing labelling issues in matchCallArgumentsImpl #38702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling issues in matchCallArgumentsImpl Unfulfilled params get arguments synthesized for them which are added to the end of the argument list. Later logic to detect out-of-order arguments and produce relabelling fixes didn't account for them though. This improves several diagnostics for mislabelled call arguments in the existing tests.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfulfilled params get arguments synthesized for them which are added to the end of the argument list. Later logic to detect out-of-order arguments and produce relabelling fixes treated them as real arguments appearing at the end of the argument list though.
This improves several diagnostics for call sites with both missing and mislabelled call arguments in the existing tests.