Allow a global-actor-isolated class to inherit from a nonisolated one. #38708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rdar://80902604.
|
@swift-ci please test |
|
@swift-ci please nominate |
airspeedswift
approved these changes
Jul 31, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: In tightening up the semantic rules around data races for class inheritance (#38213), the Swift compiler started rejecting a common pattern that is actually safe: a main-actor-isolated subclass of a non-isolated class, causing a number of apps to be incorrectly rejected. Allow this inheritance pattern.
Scope: Affects Swift code using the new concurrency features.
Radar/SR Issue: rdar://80902604
Risk: Very low. This loosens up a recently-added restriction, accepting more Swift code that was accepted before.
Testing: PR testing and CI on main.
Original PR: #38707