[IDE] Skip synthesized curry thunks and walk their unwrapped expression #38712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
slavapestov
approved these changes
Jul 31, 2021
|
Build failed |
SemaAnnotator was walking into an autoclosure and then manually running `passReference` on the unwrapped expression without walking it. Since its synthesized anyway, skip walking the autoclosure entirely and walk the unwrapped expression instead. Fix `swift::ide::isBeingCalled` to look through `IdentityExpr`s and `swift::ide::getBase` also not unwrapping curry thunks. Resolves rdar://81312849
|
Thanks for the quick review @slavapestov. Turns out the migrator was depending on |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
hamishknight
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SemaAnnotator was walking into an autoclosure and then manually running
passReferenceon the unwrapped expression without walking it. Sinceits synthesized anyway, skip walking the autoclosure entirely and walk
the unwrapped expression instead.
Fix
swift::ide::isBeingCalledto look throughIdentityExprs andswift::ide::getBasealso not unwrapping curry thunks.Resolves rdar://81312849