Make the llvm-include-tests flag actually do something #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gottesmm check this out, let me know if we need to add any other flags to this. |
| @@ -1973,6 +1973,13 @@ for host in "${ALL_HOSTS[@]}"; do | |||
| -DCLANG_TOOL_CLANG_FORMAT_BUILD=NO | |||
| ) | |||
| fi | |||
|
|
|||
| if [[ $(false_true "${LLVM_INCLUDE_TESTS}") == "FALSE" ]]; then | |||
There was a problem hiding this comment.
This is wrong. It should be checking for true.
There was a problem hiding this comment.
(i.e. false_true returns TRUE if LLVM_INCLUDE_TESTS if false.
Before this patch, it would not actually do anything unless compute_cmake_llvm_tool_disable_flags() was called, which is currently dead code, in the state of build-script-impl currently.
|
@gottesmm I fixed it up and force pushed to my fork. |
|
@swift-ci please smoke test |
|
@zisko I think milseman is going to revert the offending change. Once he does, rerun the smoketest only on linux plz. |
kateinoigakukun
added a commit
that referenced
this pull request
Aug 31, 2022
Resolve conflicts with upstream `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
The only way to set "LLVM_INCLUDE_TESTS=NO" and "CLANG_INCLUDE_TESTS=NO" in CMake currently is with the build-toolchain-only flag, but that has lots of other stuff it disables. This allows a configuration where the clang and llvm tests aren't built but everything else is (tools,etc).
The function "compute_cmake_llvm_tool_disable_flags()" never gets called, so unless you use build-toolchain-only, there is no way to not build these tests, but that flag also disables the tools.
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
Before this patch, it would not actually do anything unless
compute_cmake_llvm_tool_disable_flags()
was called, which is currently dead code, in the state of
build-script-impl currently.