Skip to content

Update the Xcode version to support Xcode 13 beta 4 #38721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 20, 2021
Merged

Update the Xcode version to support Xcode 13 beta 4 #38721

merged 8 commits into from
Aug 20, 2021

Conversation

shahmishal
Copy link
Member

@shahmishal shahmishal commented Aug 2, 2021 •
edited
Loading

(cherry picked from commit 5363a80)
cherry-picked test fixes for COW checks from main branch (#37945)

@shahmishal shahmishal requested a review from a team as a code owner August 2, 2021 05:48
@shahmishal
Copy link
Member Author

@swift-ci test new Xcode

@swift-ci
Copy link
Contributor

swift-ci commented Aug 2, 2021

Build failed
Swift Test OS X Platform
Git Sha - e017821

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@swift-ci
Copy link
Contributor

swift-ci commented Aug 5, 2021

Build failed
Swift Test OS X Platform
Git Sha - e017821

@shahmishal
Copy link
Member Author

@swift-ci test new xcode

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@swift-ci
Copy link
Contributor

swift-ci commented Aug 7, 2021

Build failed
Swift Test OS X Platform
Git Sha - e7ecb85

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@swift-ci
Copy link
Contributor

swift-ci commented Aug 9, 2021

Build failed
Swift Test OS X Platform
Git Sha - e7ecb85

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@swift-ci
Copy link
Contributor

swift-ci commented Aug 9, 2021

Build failed
Swift Test OS X Platform
Git Sha - ef06635

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@shahmishal
Copy link
Member Author

@swift-ci test

tbkka
tbkka reviewed Aug 11, 2021
View reviewed changes
shahmishal
shahmishal commented Aug 11, 2021
View reviewed changes
@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci build toolchain new Xcode

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b23ea62

shahmishal and others added 7 commits August 16, 2021 08:35
@shahmishal
Update the Xcode version to support Xcode 13 beta 4
95201f0 
(cherry picked from commit 5363a80)
@eeckstein @shahmishal
tests: refactor Array test files.
703c354 
* move all ObjC array tests into a separate file ArraysObjc.swift.gyb
* merge the remaining Arrays.swift.gyb and ArrayNew.swift.gyb files
* move the utilities from ArrayTypesAndHelpers.swift into its only use into ArraysObjc.swift.gyb

(cherry picked from commit 6f41929)
@eeckstein @shahmishal
tests: disable COW checking by default, and enable it for specific tests
96e0cb4 
COW checking needs that all libraries are consistently compiled with asserts enabled. This is not the case for the Foundation overlay anymore.
Therefore it does not work with some tests which interop with Foundation.

The solution here is to disable COW checking by default, but enable it for Array tests which do not interop with Foundation.

(cherry picked from commit 0831240)
@eeckstein @shahmishal
tests: disable COW checking by default, and enable it for specific tests
c13e531 
COW checking needs that all libraries are consistently compiled with asserts enabled. This is not the case for the Foundation overlay anymore.
Therefore it does not work with some tests which interop with Foundation.

The solution here is to disable COW checking by default, but enable it for Array tests which do not interop with Foundation.

(cherry picked from commit 0831240)
@varungandhi-apple @shahmishal
Temporarily mark ArraysObjc test unsupported for watchsimulator-i386.
5343fdc 
Earlier, I accidentally marked Arrays.swift.gyb, however the test that
is failing is ArraysObjc.swift.gyb.

(cherry picked from commit c53d0eb)
@shahmishal
Remove duplicated code
4d093f8
@nate-chandler @shahmishal
[Test] Used test header rather than SDK.
bdbf76a 
Stopped validation-test/compiler_crashers_2_fixed/rdar79383990.swift
from trying to call -[NSBackgroundActivityScheduler scheduleWithBlock:]
async--that method is now annotated NS_SWIFT_DISABLE_ASYNC.

(cherry picked from commit 4a8a647)
@shahmishal shahmishal force-pushed the update-xcode-13-beta4-5.5 branch from b23ea62 to bdbf76a Compare August 16, 2021 15:36
@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

1 similar comment
@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - bdbf76a

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci build toolchain new Xcode

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test

1 similar comment
@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci build toolchain new Xcode

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci build toolchain new Xcode

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 250fd5f

Install command
tar -zxf swift-PR-38721-4-osx.tar.gz --directory ~/

@shahmishal
Copy link
Member Author

swiftlang/swift-driver#787
@swift-ci test new Xcode

@shahmishal
Copy link
Member Author

@swift-ci test windows

eeckstein
eeckstein approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahmishal
Copy link
Member Author

@swift-ci test windows

@shahmishal shahmishal merged commit d3cf72b into release/5.5 Aug 20, 2021
@shahmishal shahmishal deleted the update-xcode-13-beta4-5.5 branch August 20, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka left review comments

@eeckstein eeckstein eeckstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shahmishal @swift-ci @eeckstein @tbkka @varungandhi-apple @nate-chandler