-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Mark legacy overloads of &+ and &- unavailable. #38723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test source compatibility |
@swift-ci please test compiler performance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Compilation-performance test failed |
These were defined for both FixedWidthInteger and FixedWidthInteger & SignedInteger for source compatibility with Swift 3; the latter set probably should have been removed when we stabilized the ABI, but were not. We can't easily remove them entirely (because we need them for ABI stability now), but we can mark them unavailable so that the typechecker doesn't have to consider them.
c62ab39
to
535ad26
Compare
@swift-ci smoke test |
@swift-ci smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
The source compat checker uses a separate exceptions file, so I expect it'll still complain.
@swift-ci please smoke test |
@swift-ci please test source compatibility |
@swift-ci please test source compatibility |
@swift-ci please test compiler performance |
@swift-ci please test |
Build failed |
@swift-ci smoke test |
@swift-ci please test source compatibility |
@swift-ci test |
Build failed |
Linux failure is unrelated, compatibility suite looks to be noise. |
These were defined for both FixedWidthInteger and FixedWidthInteger & SignedInteger for source compatibility with Swift 3; the latter set probably should have been removed when we stabilized the ABI, but were not. We can't easily remove them entirely (because we need them for ABI stability now), but we can mark them unavailable so that the typechecker doesn't have to consider them.
https://forums.swift.org/t/very-long-compilation-times-with-custom-and-but-not-with-and/50789/3