Start testing Swift 6 mode changes #38742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow us to start testing language changes tied to a future Swift 6 mode without actually *shipping* a Swift 6 mode to customers who might accidentally use it before it's ready. This commit also adds parallel tests for a number of already existing (but untested) Swift 6 mode behaviors.
This change was approved for Swift 6 mode in SE-0274/SE-0285.
|
@swift-ci test |
kavon
approved these changes
Aug 11, 2021
Comment on lines
+9
to
+10
| // ERROR_7: <unknown>:0: note: valid arguments to '-swift-version' | ||
| // ERROR_7-NOT: '6' |
There was a problem hiding this comment.
Are we missing a FileCheck invocation that uses ERROR_7 as the prefix?
|
I'm going to merge this now so we can start building on it. |
|
I do wonder if we should use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes asserts compilers only accept
-swift-version 6so that we can begin to test source-breaking changes intended for the next language version mode, but without shipping that unfinished work to Swift users. It also adds tests for existing Swift 6 mode behaviors (mostly warnings being strengthened into errors) and enables the changes to#fileapproved in SE-0274/SE-0285 for Swift 6 mode.Tests that wish to use
-swift-version 6currently must be marked withREQUIRES: assertsor they will fail in no-asserts bots. The simplest pattern is probably to duplicate part or all of the Swift 5 test to check that will behave as intended in Swift 6.