Fix an assert in collectUses when handling unknown index offsets. #38757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Also need a follow up fix to recognize the offset accurately when there is a |
AccessPathDefUseTraversal accumulates the offsets that it has seen on the def-use walk while visiting index_addr and casts. This is quite tricky because either the AccessPath being matched or the def-use chain could contain unknown offsets. We need to correctly classify all cases as either an exact, inner, or overlapping match. For SIL like this %91 = integer_literal $Builtin.Int64, 0 %113 = builtin "truncOrBitCast_Int64_Word"(%91 : $Builtin.Int64) : $Builtin.Word %115 = index_addr %114 : $*MyStruct, %113 : $Builtin.Word %119 = struct_element_addr %115 : $*MyStruct, #MyStruct.klass We have Path: (@unknown,#0) There are two issues (1) When AccessPathDefUseTraversal::checkAndUpdateOffset visits the struct_element_addr, it fails to pop the unknown offset from the expected path but continues trying to handle the struct_element_addr and hits an assert. This PR fixes this. (2) If the builtin "truncOrBitCast_Int64_Word" comes from a literal, we should not treat it as an unknown offset (given that the literal is within the size of a word). Added a test for this case, we should be able to identify the access path accurately in this.
meg-gupta
force-pushed
the
accesspathfixpr
branch
from
2c7bc8a to
c323c62
Compare
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci test OSX platform |
|
@swift-ci test Linux platform |
|
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up the fix from #38492. Added tests.