ClangImporter: NFC: simplify importFullName calls
#38764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
How about we refactor |
This is just a cleanup of `importFullName` invocations, discussed here: swiftlang#37695 (comment) This change makes `importFullName` return a pair of a canonical & alternative names instead of having one of them passed as a parameter.
|
@CodaFi sounds good, that seems to be a cleaner solution. |
egorzhdan
force-pushed
the
clangimporter-cleanup
branch
from
15edc2f to
4a41405
Compare
|
@swift-ci please smoke test |
CodaFi
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a cleanup of
importFullNameinvocations, discussed here: #37695 (comment)This change makes
importFullNamereturn a pair of a canonical & alternative names instead of having one of them passed as a parameter.