RequirementMachine: Speed up property map lookups with a suffix trie #38776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r longest-suffix match The PropertyMap wants to use a try to map to PropertyBags, and it needs longest-suffix rather than shortest-prefix matching. Implement both by making Trie into a template class with two parameters; the ValueType, and the MatchKind. Note that while the MatchKind encodes the longest vs shortest match part, matching on the prefix vs suffix of a term is up to the caller, since the find() and insert() methods of Trie take a pair of iterators, so simply passing in begin()/end() vs rbegin()/rend() selects the direction.
Whereas term simplification uses a prefix trie with shortest matching, the PropertyMap uses a suffix trie with longest matching.
… as keys Also, we don't have to sort rules in term order before adding them to the map; a bucket sort by term length is sufficient.
slavapestov
force-pushed
the
requirement-machine-property-map-trie
branch
2 times, most recently
from
b3c190f to
9738d4e
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequel to #38775.