Fix serialization crashes found from stress tester #38779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7856f2d only partially skipped writing out destructors when they were invalid, ie. it skipped writing the decl itself but not the records common to all decls. This would cause any records on the destructor to be applied on the next serialized decl. Make sure to skip serializing anything to do with the destructor when it's invalid and does not have a class context.
An invalid PDB may have no anchoring VarDecl when allowing errors, make sure not to crash in that case.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran another stress tester in preparation for merging the TestModule request, which found a couple new issues: