Skip to content

Fix use of MemAcessUtils in LICM #38784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2021
Merged

Fix use of MemAcessUtils in LICM #38784

merged 1 commit into from
Aug 7, 2021

Conversation

meg-gupta
Copy link
Contributor

AccessPathWithBase::compute can return a valid access path with unidentified base.
In such cases, we cannot LICM stores, because there is no base address to check if it is invariant

@meg-gupta meg-gupta requested a review from atrick August 6, 2021 17:33
@meg-gupta
Fix use of MemAcessUtils in LICM
7c62a81 
AccessPathWithBase::compute can return a valid access path with unidentified base.
In such cases, we cannot LICM stores, because there is no base address to check if it is invariant
@meg-gupta
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 6, 2021

Build failed
Swift Test OS X Platform
Git Sha - 7c62a81

@meg-gupta
Copy link
Contributor Author

@swift-ci test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Aug 6, 2021

Build failed
Swift Test OS X Platform
Git Sha - 7c62a81

atrick
atrick approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm documenting this case in a separate PR. We need to support multiple bases for the same storage. In this case, multiple ref_tail_addr's. Typically, we should avoid those SIL patterns, but it might be unavoidable with index_addr.

@meg-gupta
Copy link
Contributor Author

@swift-ci test macOS platform

@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test

@meg-gupta meg-gupta merged commit 64095a6 into swiftlang:main Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meg-gupta @swift-ci @atrick